Fix: email format by abdulaba · Pull Request #5714 · heartcombo/devise

abdulaba · 2024-09-16T17:52:22Z

Problem: You can register an invalid email: john.doe@gmail
Fix: Regular expresion

devise.rb

@@email_regexp = /\A[^@\s]+@[^@\s]+.[^@\s]+\z/

rafaeldev · 2024-09-23T03:01:26Z

I figured out this point and I fixed it in devise.rb config file with:
config.email_regexp = /\A[\w+\-.]+@[a-z\d\-]+(\.[a-z]+)*\.[a-z]+\z/i

I don't remember where I saw it, but that default simple validation is for solving some local case emails

abdulaba · 2024-09-23T14:01:35Z

Great! Thanks for answering. Best regards Andrés Ibáñez Ulloa El El lun, 23 de sep. de 2024 a la(s) 00:01, Rafael Gomes < ***@***.***> escribió:

Hi @abdulaba <https://github.com/abdulaba> ! I figured out this point and I fixed it in devise.rb config file with: config.email_regexp = ***@***.***\d\-]+(\.[a-z]+)*\.[a-z]+\z/i I don't remember where I saw it, but that default simple validation is for solving some local case emails — Reply to this email directly, view it on GitHub <#5714 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALJSPLD7SUT3GE3ALDJFNYLZX6ABXAVCNFSM6AAAAABOJZW6LCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRXGE2TEMRRGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

Fix: email format

1eaaf0c

ghost approved these changes Sep 23, 2024

View reviewed changes

carlosantoniodasilva added this to the 5.1.0 milestone Feb 16, 2026